Drop CA_RISCV_ENABLED CMake option. #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
reviewed
Feb 18, 2025
hvdijk
force-pushed
the
drop-riscv-enabled
branch
2 times, most recently
from
f04e99b to
c2f792a
Compare
coldav
reviewed
Feb 19, 2025
coldav
reviewed
Feb 19, 2025
hvdijk
force-pushed
the
drop-riscv-enabled
branch
4 times, most recently
from
f3d0ce9 to
d74316e
Compare
The CA_(target)_ENABLED options were provided because we simultaneously wanted to enable all available Mux targets by default, and disable the RISC-V Mux target by default. This is confusing when CA_RISCV_ENABLED and CA_MUX_TARGETS_TO_ENABLE are mismatched: it causes the RISC-V Mux target to be disabled when either variable disables it, even when the other variable suggests that it should be enabled. Drop CA_(target)_ENABLED and rely entirely on CA_MUX_TARGETS_TO_ENABLE instead. For consistency, make the same change to CA_MUX_COMPILERS_TO_ENABLE. For CA_MUX_TARGETS_TO_ENABLE, change the default to "host". For CA_MUX_COMPILERS_TO_ENABLE, change the default to match CA_MUX_TARGETS_TO_ENABLE. Update the documentation and continuous integration to set them where we do not want host and were not already setting them.
hvdijk
force-pushed
the
drop-riscv-enabled
branch
from
d74316e to
6b8255e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Drop CA_RISCV_ENABLED CMake option.
Reason for change
The CA_RISCV_ENABLED option was provided because we simultaneously want to enable all available Mux targets by default, and disable the RISC-V Mux target by default. This is confusing when CA_RISCV_ENABLED and CA_MUX_TARGETS_TO_ENABLE are mismatched: it causes the RISC-V Mux target to be disabled when either variable disables it, even when the other variable suggests that it should be enabled.
Description of change
Drop CA_RISCV_ENABLED and rely entirely on CA_MUX_TARGETS_TO_ENABLE instead.
For consistency, make the same change to CA_MUX_COMPILERS_TO_ENABLE.
For both CA_MUX_TARGETS_TO_ENABLE and CA_MUX_COMPILERS_TO_ENABLE, change the default to "host": we expect builds that rely on other targets or other compilers to already explicitly specify the desired target and compiler.
Anything else we should know?
If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.
Checklist